You should want similar things in life
Core values should not clash,
Lifestyle should be harmonious,
Liking for each other's personality
Good communication


Check feasibility of complementing/managing their shortcomings/weaknesses (if they are impatient, can you keep a check on yourself and figure out the solution while they throw tantrums?). Enjoy and appreciate their strengths.